fix(geo): Record subregion name instead of M49 region code - #6049
Closed
mjq wants to merge 1 commit into
Closed
Conversation
mjq
changed the title
Member
Author
|
I'm going to close this - people aren't asking for it and I found some existing uses of the code. If we do this it would have to be in a backward compatible way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sentry.user.geo.subregionattribute previously contained the M49 geographic region code - for example, if the user was located in Eastern Europe, the value ofsentry.user.geo.subregionwould be"151".This isn't very usable, and is unlikely the actual semantics we want for this field when we create a new, non-
sentry.-prefixed version of it for conventions.Replace the value of this field with a string label for the detected region (so
sentry.user.geo.subregionfor a user in Eastern Europe would now be"Eastern Europe").This is a breaking change if anyone is using this field in dashboards, alerts, etc.